Fix memory leak of a CGPathRef #1649
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greghe
changed the title
|
Would be awesome if this could get merged. We are also experiencing this issue. Looks like a simple fix? |
|
I'd love to remove my local patch for this fix. Any idea when this will make it into a release? |
javache
approved these changes
Oct 25, 2023
|
@javache hi, is there any reason why this is not merged yet? Thanks |
|
Hi, Could someone explain how we can reproduce that nowadays? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Regarding issue #1385
Fixes memory leak of a CGPathRef.
Explain the motivation for making this change: here are some points to help you:
CGPath leaks listed in Xcode:
Backtrace of leaked object, identifying RNSVGUse as the object that leaked the CGPathRef:
What issues does the pull request solve? Please tag them so that they will get automatically closed once the PR is merged
Issue Memory leaks in RNSVGUse getPath? #1385
What is the feature? (if applicable)
Memory leak fix
How did you implement the solution?
Added a call to autorelease returned CGPathRef in line with the other implementations of
getPath:What areas of the library does it impact?
Test Plan
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
What's required for testing (prerequisites)?
Running an app that uses react-native-svg in the Xcode debugger with malloc stack tracing enabled.
What are the steps to reproduce (after prerequisites)?
Halt the app in the debugger and examine memory graph, specifically the leaked objects filter (by clicking on the blue triangle icon)
Compatibility
Checklist
README.md__tests__folder